dajac commented on code in PR #16826:
URL: https://github.com/apache/kafka/pull/16826#discussion_r1707012146
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##########
@@ -3206,14 +3208,21 @@ public void testRefreshOffsetUnknownTopicOrPartition() {
assertThrows(KafkaException.class, () ->
coordinator.initWithCommittedOffsetsIfNeeded(time.timer(Long.MAX_VALUE)));
}
- @Test
- public void testRefreshOffsetNotCoordinatorForConsumer() {
+ @ParameterizedTest
+ @CsvSource({
+ "NOT_COORDINATOR, true",
+ "COORDINATOR_NOT_AVAILABLE, true",
+ "NETWORK_EXCEPTION, false",
+ })
+ public void testRefreshOffsetRetriableErrors(Errors error, boolean
expectCoordinatorRelookup) {
Review Comment:
I wonder if we could make it clear in the name that this test is about
verifying that the coordinator looked up for those errors. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
