squah-confluent commented on code in PR #16825:
URL: https://github.com/apache/kafka/pull/16825#discussion_r1709410881
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -1176,4 +1176,34 @@ private <IN, OUT> OUT handleOperationException(
return handler.apply(apiError.error(), apiError.message());
}
}
+
+ /**
+ * This is the handler used by offset fetch operations to convert errors
to coordinator errors.
+ *
+ * @param request The OffsetFetchRequestGroup request.
+ * @param exception The exception to handle.
+ * @return The OffsetFetchRequestGroup response.
+ */
+ private OffsetFetchResponseData.OffsetFetchResponseGroup
handleOffsetFetchException(
+ OffsetFetchRequestData.OffsetFetchRequestGroup request,
+ Throwable exception
+ ) {
+ ApiError apiError = ApiError.fromThrowable(exception);
+
+ switch (apiError.error()) {
+ case REQUEST_TIMED_OUT:
+ // Remap REQUEST_TIMED_OUT to NOT_COORDINATOR, otherwise older
consumers will not
Review Comment:
Yes, good idea. I've updated the comment to mention version 3.9.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
