DL1231 commented on code in PR #15067: URL: https://github.com/apache/kafka/pull/15067#discussion_r1709619817
########## core/src/main/scala/kafka/server/KafkaConfig.scala: ########## @@ -1119,6 +1119,16 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) logProps } + /** + * Copy the subset of properties that are relevant to consumer group. + */ + def extractGroupConfigMap: java.util.Map[String, Int] = { + val groupProps = new java.util.HashMap[String, Int]() + groupProps.put(GroupConfig.CONSUMER_SESSION_TIMEOUT_MS_CONFIG, groupCoordinatorConfig.consumerGroupSessionTimeoutMs) + groupProps.put(GroupConfig.CONSUMER_HEARTBEAT_INTERVAL_MS_CONFIG, groupCoordinatorConfig.consumerGroupHeartbeatIntervalMs) + groupProps + } Review Comment: Yes it makes sense to me. Moved this method to `GroupCoordinatorConfig`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org