kirktrue commented on PR #16567: URL: https://github.com/apache/kafka/pull/16567#issuecomment-2276133338
> Thanks for taking a look @kirktrue. I don't believe additional synchronization is necessary. Thanks for your explanation, @C0urante! TBH, I can't quite recall my concern. I think it was that I'd noticed that the `close()` method checks for `rebalanceConfig.leaveGroupOnClose` and calls `maybeLeaveGroup()` _with_ synchronization while `JoinGroupResponseHandler.handle()` also checks `rebalanceConfig.leaveGroupOnClose` and calls `maybeLeaveGroup()`, _without_ synchronization. That said, I don't know the existing rebalance protocol and code very well so I can't articulate a specific case where that would be a problem. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
