junrao commented on code in PR #16841:
URL: https://github.com/apache/kafka/pull/16841#discussion_r1711938781
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -244,7 +244,7 @@ public enum MetadataVersion {
* <strong>Think carefully before you update this value. ONCE A METADATA
VERSION IS PRODUCTION,
* IT CANNOT BE CHANGED.</strong>
*/
- public static final MetadataVersion LATEST_PRODUCTION = IBP_3_8_IV0;
+ public static final MetadataVersion LATEST_PRODUCTION = IBP_3_9_IV0;
Review Comment:
Hmm, ListOffsetRequest has latestVersionUnstable set to true. So, it's kind
of weird to have a production MV depending on a unstable PRC.
@clolov @showuon @chia7712 : Is KIP-1005 done? Could we set
latestVersionUnstable to false for ListOffsetRequest in 3.9?
##########
server-common/src/main/java/org/apache/kafka/server/common/TestFeatureVersion.java:
##########
@@ -23,8 +23,8 @@ public enum TestFeatureVersion implements FeatureVersion {
TEST_0(0, MetadataVersion.MINIMUM_KRAFT_VERSION, Collections.emptyMap()),
// TEST_1 released right before MV 3.7-IVO was released, and it has no
dependencies
TEST_1(1, MetadataVersion.IBP_3_7_IV0, Collections.emptyMap()),
- // TEST_2 released right before MV 3.9-IVO was released, and it depends on
this metadata version
- TEST_2(2, MetadataVersion.IBP_3_9_IV0,
Collections.singletonMap(MetadataVersion.FEATURE_NAME,
MetadataVersion.IBP_3_9_IV0.featureLevel()));
+ // TEST_2 released right before MV 4.0-IVO was released, and it depends on
this metadata version
+ TEST_2(2, MetadataVersion.IBP_4_0_IV0,
Collections.singletonMap(MetadataVersion.FEATURE_NAME,
MetadataVersion.IBP_4_0_IV0.featureLevel()));
Review Comment:
@jolshan : What MV should TEST_2 depend on? Do we need to keep changing it
with new MVs? It would be useful to add a comment to document this.
##########
metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java:
##########
@@ -389,7 +389,7 @@ public void
testNoLeaderEpochBumpOnIsrExpansionDuringMigration(String metadataVe
* always results in a leader epoch increase.
*/
@ParameterizedTest
- @ValueSource(strings = {"3.4-IV0", "3.5-IV2", "3.6-IV0", "3.7-IV2",
"3.9-IV1"})
+ @ValueSource(strings = {"3.4-IV0", "3.5-IV2", "3.6-IV0", "3.7-IV2",
"4.0-IV0"})
Review Comment:
I had a followup comment in
https://github.com/apache/kafka/pull/16347#discussion_r1661558720. Do we need
to add 4.0-IV0 for `testNoLeaderEpochBumpOnEmptyTargetIsr`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
