[
https://issues.apache.org/jira/browse/KAFKA-7332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16618638#comment-16618638
]
ASF GitHub Bot commented on KAFKA-7332:
---------------------------------------
lindong28 closed pull request #5638: KAFKA-7332: Update CORRUPT_MESSAGE
exception message description
URL: https://github.com/apache/kafka/pull/5638
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/clients/src/main/java/org/apache/kafka/common/protocol/Errors.java
b/clients/src/main/java/org/apache/kafka/common/protocol/Errors.java
index a796ec912cb..082eff12461 100644
--- a/clients/src/main/java/org/apache/kafka/common/protocol/Errors.java
+++ b/clients/src/main/java/org/apache/kafka/common/protocol/Errors.java
@@ -116,7 +116,7 @@
NONE(0, null, message -> null),
OFFSET_OUT_OF_RANGE(1, "The requested offset is not within the range of
offsets maintained by the server.",
OffsetOutOfRangeException::new),
- CORRUPT_MESSAGE(2, "This message has failed its CRC checksum, exceeds the
valid size, or is otherwise corrupt.",
+ CORRUPT_MESSAGE(2, "This message has failed its CRC checksum, exceeds the
valid size, has a null key for a compacted topic, or is otherwise corrupt.",
CorruptRecordException::new),
UNKNOWN_TOPIC_OR_PARTITION(3, "This server does not host this
topic-partition.",
UnknownTopicOrPartitionException::new),
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve error message when trying to produce message without key for
> compacted topic
> ------------------------------------------------------------------------------------
>
> Key: KAFKA-7332
> URL: https://issues.apache.org/jira/browse/KAFKA-7332
> Project: Kafka
> Issue Type: Improvement
> Components: producer
> Affects Versions: 1.1.0
> Reporter: Patrik Kleindl
> Assignee: Manikumar
> Priority: Trivial
> Fix For: 2.1.0
>
>
> Goal:
> Return a specific error message like e.g. "Message without a key is not valid
> for a compacted topic" when trying to produce such a message instead of a
> CorruptRecordException.
>
> > Yesterday we had the following exception:
> >
> > Exception thrown when sending a message with key='null' and payload='...'
> > to topic sometopic:: org.apache.kafka.common.errors.CorruptRecordException:
> > This message has failed its CRC checksum, exceeds the valid size, or is
> > otherwise corrupt.
> >
> > The cause was identified with the help of
> >
> >[https://stackoverflow.com/questions/49098274/kafka-stream-get-corruptrecordexception]
> >
> > Is it possible / would it makes sense to open an issue to improve the error
> > message for this case?
> > A simple "Message without a key is not valid for a compacted topic" would
> > suffice and point a user in the right direction.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
