cmccabe commented on code in PR #16841:
URL: https://github.com/apache/kafka/pull/16841#discussion_r1714319798
##########
metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java:
##########
@@ -389,7 +389,7 @@ public void
testNoLeaderEpochBumpOnIsrExpansionDuringMigration(String metadataVe
* always results in a leader epoch increase.
*/
@ParameterizedTest
- @ValueSource(strings = {"3.4-IV0", "3.5-IV2", "3.6-IV0", "3.7-IV2",
"3.9-IV1"})
+ @ValueSource(strings = {"3.4-IV0", "3.5-IV2", "3.6-IV0", "3.7-IV2",
"4.0-IV0"})
Review Comment:
It would not make sense to add 4.0-IV0 to
`testNoLeaderEpochBumpOnEmptyTargetIsr`, since in 4.0 an empty target ISR
actually WILL trigger a leader epoch bump.
The reason is because once KIP-966 is implemented, empty ISRs will actually
be possible, whereas they are not prior to KIP-966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
