lianetm commented on code in PR #16673:
URL: https://github.com/apache/kafka/pull/16673#discussion_r1716945286
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/AssignmentChangeEvent.java:
##########
@@ -16,33 +16,31 @@
*/
package org.apache.kafka.clients.consumer.internals.events;
-import org.apache.kafka.clients.consumer.OffsetAndMetadata;
import org.apache.kafka.common.TopicPartition;
-import java.util.Collections;
-import java.util.Map;
+import java.util.Collection;
-public class AssignmentChangeEvent extends ApplicationEvent {
+public class AssignmentChangeEvent extends CompletableApplicationEvent<Void> {
- private final Map<TopicPartition, OffsetAndMetadata> offsets;
private final long currentTimeMs;
Review Comment:
oh you're right. I guess I was looking at my local branch when adding that
comment (not trunk). I'm adding a `Time` object to appEventProcessor for the
changes I'm working on
([KAFKA-17066](https://issues.apache.org/jira/browse/KAFKA-17066)). So let's
just leave the currentTime unchanged here, and I'll do the simplification on
that other PR that is introducing the Time already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
