chia7712 commented on code in PR #16658:
URL: https://github.com/apache/kafka/pull/16658#discussion_r1715510720


##########
core/src/test/scala/integration/kafka/admin/AdminFenceProducersIntegrationTest.scala:
##########
@@ -107,6 +110,43 @@ class AdminFenceProducersIntegrationTest extends 
IntegrationTestHarness {
     assertThrows(classOf[ProducerFencedException], () => 
producer.commitTransaction())
   }
 
+  @ParameterizedTest
+  @ValueSource(strings = Array("zk", "kraft"))
+  @Timeout(value = 30)
+  def testFenceProducerTimeoutMs(quorum: String): Unit = {

Review Comment:
   this test case is used to verify the timeout, so we don't need to send 
transaction actually. 
   
   ```scala
     @ParameterizedTest
     @ValueSource(strings = Array("zk", "kraft"))
     @Timeout(value = 30)
     def testFenceProducerTimeoutMs(quorum: String): Unit = {
       val config = createConfig
       config.put(AdminClientConfig.BOOTSTRAP_SERVERS_CONFIG, 
s"localhost:${TestUtils.IncorrectBrokerPort}")
       val admin = Admin.create(config)
       try {
         val e = assertThrows(classOf[ExecutionException], () => 
admin.fenceProducers(Collections.singletonList(txnId),
           new FenceProducersOptions().timeoutMs(0)).all().get())
         assertInstanceOf(classOf[TimeoutException], e.getCause)
       } finally admin.close(time.Duration.ZERO)
     }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to