smjn commented on code in PR #16883:
URL: https://github.com/apache/kafka/pull/16883#discussion_r1720959346
##########
settings.gradle:
##########
@@ -57,6 +57,7 @@ include 'clients',
'connect:runtime',
'connect:test-plugins',
'connect:transforms',
+ 'coordinator-common',
Review Comment:
Mainly 2 reasons for the current name.
1. The new parent coordinator module does not do anything useful on its own.
`common-coordinator` has the connotation that this module serves a well defined
purpose like group coordinator but that is not the case. It just runs the
framework classes and the useful work is only done when a cooperating
coordinator provides concrete implementations. You are also right in pointing
out the server-common nomenclature. But in the same spirit common-server has a
very different connotation and seems incorrect.
2. The original author of the group-coordinator suggested the name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
