chia7712 commented on code in PR #16910: URL: https://github.com/apache/kafka/pull/16910#discussion_r1721040005
########## server/src/main/java/org/apache/kafka/server/config/ReplicationConfigs.java: ########## @@ -122,7 +122,8 @@ public class ReplicationConfigs { public static final String INTER_BROKER_PROTOCOL_VERSION_DEFAULT = MetadataVersion.latestProduction().version(); public static final String INTER_BROKER_PROTOCOL_VERSION_DOC = "Specify which version of the inter-broker protocol will be used.\n" + ". This is typically bumped after all brokers were upgraded to a new version.\n" + - " Example of some valid values are: 0.8.0, 0.8.1, 0.8.1.1, 0.8.2, 0.8.2.0, 0.8.2.1, 0.9.0.0, 0.9.0.1 Check MetadataVersion for the full list."; + " Example of some valid values are: 0.8.0, 0.8.1, 0.8.1.1, 0.8.2, 0.8.2.0, 0.8.2.1, 0.9.0.0, 0.9.0.1 Check MetadataVersion for the full list.\n" + + "This configuration is only applicable in Zookeeper mode, Use `metadata.version` config for KRaft instead."; Review Comment: pardon me, do we have "metadata.version" config? According to `kafka-storage.sh`, the related config name is `release-version` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org