chia7712 commented on code in PR #16849:
URL: https://github.com/apache/kafka/pull/16849#discussion_r1721045440
##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##########
@@ -876,7 +876,7 @@ public void testUnsupportedFindCoordinator() {
client.prepareUnsupportedVersionResponse(body -> {
FindCoordinatorRequest findCoordinatorRequest =
(FindCoordinatorRequest) body;
assertEquals(CoordinatorType.forId(findCoordinatorRequest.data().keyType()),
CoordinatorType.TRANSACTION);
- assertEquals(findCoordinatorRequest.data().key(), transactionalId);
Review Comment:
The key should be empty as the request is using the batch keys. Also, the
collection of `coordinatorKeys` should include only one element (copy from
`key`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
