mumrah commented on code in PR #16900:
URL: https://github.com/apache/kafka/pull/16900#discussion_r1722314406
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -666,7 +666,6 @@ private void transitionToResigned(List<ReplicaKey>
preferredSuccessors) {
fetchPurgatory.completeAllExceptionally(
Errors.NOT_LEADER_OR_FOLLOWER.exception("Not handling request
since this node is resigning"));
quorum.transitionToResigned(preferredSuccessors);
- maybeFireLeaderChange();
Review Comment:
If we are not notifying the RaftListener-s about the loss in leadership
here, and we're not doing it in pollListeners, where do we do it? Or Is it the
case that we do not notify about this event any more and simply let writes fail?
Assuming a listener does not attempt a write, when will they learn about the
new epoch? Once the raft client becomes a candidate in the new epoch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
