unknowntpo commented on code in PR #16648:
URL: https://github.com/apache/kafka/pull/16648#discussion_r1723339500
##########
clients/src/main/java/org/apache/kafka/clients/admin/ExpireDelegationTokenOptions.java:
##########
@@ -28,6 +28,13 @@
public class ExpireDelegationTokenOptions extends
AbstractOptions<ExpireDelegationTokenOptions> {
private long expiryTimePeriodMs = -1L;
+ /**
+ * @param expiryTimePeriodMs the time period until we should expire this
token.
+ * {@code expiryTimestamp} is the time we actually expire the token.
+ * If {@code expiryTimePeriodMs} < 0, token will be expired immediately.
+ * If {@code expiryTimePeriodMs} >= 0 and {@code expiryTimestamp} is not
due,
+ * {@code expiryTimestamp} will be set to {@code min(expiryTimestamp,
maxTimestamp)}.
Review Comment:
okay, I'll change it to
```
/**
* @param expiryTimePeriodMs the time period until we should expire this
token.
* {@code expiryTimePeriodMs} >= 0: the token will update the
`expiration timestamp` if the current expiration timestamp is small than (now +
expiryTimePeriodMs).
* {@code expiryTimePeriodMs} < 0: token will be expired immediately.
*/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
