chia7712 commented on code in PR #16493:
URL: https://github.com/apache/kafka/pull/16493#discussion_r1723911859
##########
core/src/test/java/kafka/test/ClusterInstance.java:
##########
@@ -204,4 +207,13 @@ default void waitForTopic(String topic, int partitions)
throws InterruptedExcept
60000L, "Timeout waiting for controller metadata propagating
to brokers");
}
}
+
Review Comment:
for another, please add `waitAcls`. for example:
```java
default void waitAcls(AclBindingFilter filter,
Collection<AccessControlEntry> entries) throws InterruptedException {
for (Authorizer authorizer : authorizers()) {
TestUtils.waitForCondition(() -> {
Assertions.assertIterableEquals(authorizer.acls(filter),
entries);
return true;
}, "except: ");
}
}
```
##########
core/src/test/java/kafka/test/ClusterInstance.java:
##########
@@ -204,4 +207,13 @@ default void waitForTopic(String topic, int partitions)
throws InterruptedExcept
60000L, "Timeout waiting for controller metadata propagating
to brokers");
}
}
+
+ default List<Authorizer> authorizers() {
Review Comment:
Could you please check the existence of `Option` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
