chia7712 commented on code in PR #16932:
URL: https://github.com/apache/kafka/pull/16932#discussion_r1724287034
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1601,7 +1601,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
shouldDelete
}
- deleteOldSegments(shouldDelete, RetentionSizeBreach(this,
remoteLogEnabled()))
+ deleteOldSegments(shouldDelete, RetentionSizeBreach(this,
remoteLogEnabledAndRemoteCopyEnabled()))
}
private def deleteLogStartOffsetBreachedSegments(): Int = {
Review Comment:
please apply `remoteLogEnabledAndRemoteCopyEnabled` to
`deleteLogStartOffsetBreachedSegments` also
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -108,13 +108,13 @@ public String topicWarningMessage(String topicName) {
}
}
- public static class RemoteLogConfig {
+ private static class RemoteLogConfig {
Review Comment:
Could you please change line#378 from `public` to `private`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
