mumrah commented on code in PR #16957:
URL: https://github.com/apache/kafka/pull/16957#discussion_r1727651045


##########
core/src/test/java/kafka/test/annotation/ClusterTest.java:
##########
@@ -34,6 +35,7 @@
 @Target({METHOD})
 @Retention(RUNTIME)
 @TestTemplate
+@Timeout(30)

Review Comment:
   Does this work? I know we have tried setting global timeouts in the past 
with no success.
   
   Also, 30 seconds might be too short for `ClusterTest` tests since these are 
integration tests. I think 120 is more reasonable.
   
   Can you add a new test that just sleeps for 5 minutes to verify the 
behavior? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to