mjsax commented on code in PR #16050:
URL: https://github.com/apache/kafka/pull/16050#discussion_r1728144339
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignorConvergenceTest.java:
##########
@@ -623,11 +622,10 @@ private static void testForConvergence(final Harness
harness,
}
if (rebalancePending) {
- final StringBuilder message =
- new StringBuilder().append("Rebalances have not converged
after iteration cutoff: ")
- .append(iterationLimit)
- .append(harness.history);
- fail(message.toString());
+ final String message = "Rebalances have not converged after
iteration cutoff: " +
+ iterationLimit +
+ harness.history;
+ fail(message);
Review Comment:
If we move off `StringBuilder` than we can get rid of `String messsage`,
too, and put the string directly into `fail(...)`
And we can change the formatting...
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignorConvergenceTest.java:
##########
@@ -569,11 +569,10 @@ private static void verifyBalancedAssignment(final
Harness harness, final int sk
final AssignmentTestUtils.TaskSkewReport taskSkewReport =
AssignmentTestUtils.analyzeTaskAssignmentBalance(harness.clientStates,
skewThreshold);
if (taskSkewReport.totalSkewedTasks() > 0) {
fail(
- new StringBuilder().append("Expected a balanced task
assignment, but was: ")
- .append(taskSkewReport)
- .append('\n')
- .append(failureContext)
- .toString()
+ "Expected a balanced task assignment, but was: " +
Review Comment:
Seem we can use better formatting when removing `StringBuilder`
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java:
##########
@@ -396,27 +395,25 @@ private static void
validateAndAddStandbyAssignments(final Set<TaskId> statefulT
for (final TaskId standbyTask : entry.getValue().standbyTasks()) {
if (statelessTasks.contains(standbyTask)) {
throw new AssertionError(
- new StringBuilder().append("Found a standby task for
stateless task ")
- .append(standbyTask)
- .append(" on client ")
- .append(entry)
- .append(" stateless tasks:")
- .append(statelessTasks)
- .append(failureContext)
- .toString()
+ "Found a standby task for stateless task " +
Review Comment:
Seem we can use better formatting when removing `StringBuilder`
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java:
##########
@@ -373,16 +373,15 @@ static void assertValidAssignment(final int
numStandbyReplicas,
if (!misassigned.isEmpty()) {
assertThat(
- new StringBuilder().append("Found some over- or under-assigned
tasks in the final assignment with ")
- .append(numStandbyReplicas)
- .append(" and max warmups ")
- .append(maxWarmupReplicas)
- .append(" standby replicas, stateful
tasks:")
- .append(statefulTasks)
- .append(", and stateless tasks:")
- .append(statelessTasks)
- .append(failureContext)
- .toString(),
+ "Found some over- or under-assigned tasks in the final
assignment with " +
Review Comment:
Seem we can use better formatting when removing `StringBuilder`
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java:
##########
@@ -396,27 +395,25 @@ private static void
validateAndAddStandbyAssignments(final Set<TaskId> statefulT
for (final TaskId standbyTask : entry.getValue().standbyTasks()) {
if (statelessTasks.contains(standbyTask)) {
throw new AssertionError(
- new StringBuilder().append("Found a standby task for
stateless task ")
- .append(standbyTask)
- .append(" on client ")
- .append(entry)
- .append(" stateless tasks:")
- .append(statelessTasks)
- .append(failureContext)
- .toString()
+ "Found a standby task for stateless task " +
+ standbyTask +
+ " on client " +
+ entry +
+ " stateless tasks:" +
+ statelessTasks +
+ failureContext
);
} else if (assignments.containsKey(standbyTask)) {
assignments.get(standbyTask).add(entry.getKey());
} else {
throw new AssertionError(
- new StringBuilder().append("Found an extra standby task ")
- .append(standbyTask)
- .append(" on client ")
- .append(entry)
- .append(" but expected stateful tasks:")
- .append(statefulTasks)
- .append(failureContext)
- .toString()
+ "Found an extra standby task " +
Review Comment:
Seem we can use better formatting when removing `StringBuilder`
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/AssignmentTestUtils.java:
##########
@@ -432,16 +429,15 @@ private static void validateAndAddActiveAssignments(final
Set<TaskId> statefulTa
assignments.get(activeTask).add(entry.getKey());
} else {
throw new AssertionError(
- new StringBuilder().append("Found an extra active task ")
- .append(activeTask)
- .append(" on client ")
- .append(entry)
- .append(" but expected stateful tasks:")
- .append(statefulTasks)
- .append(" and stateless tasks:")
- .append(statelessTasks)
- .append(failureContext)
- .toString()
+ "Found an extra active task " +
Review Comment:
Seem we can use better formatting when removing `StringBuilder`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
