frankvicky commented on code in PR #16974:
URL: https://github.com/apache/kafka/pull/16974#discussion_r1728682589
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestManager.java:
##########
@@ -59,7 +59,7 @@ public interface RequestManager {
* <em>all</em> request managers is critical to ensure that we can
complete as many of the consumer's shutdown
* tasks as possible within the user-provided timeout.
*/
- default PollResult pollOnClose() {
+ default PollResult pollOnClose(long currentTimeMs) {
Review Comment:
nit: Since we’ve added a new parameter currentTimeMs: long, I think we
should add a description of this new parameter to the JavaDoc of the method.
This would also help us align with the pull method.
WYDT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
