mjsax commented on code in PR #16914:
URL: https://github.com/apache/kafka/pull/16914#discussion_r1729586240
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java:
##########
@@ -436,6 +430,8 @@ private StateConsumer initialize() {
} catch (final Exception fatalException) {
closeStateConsumer(stateConsumer, false);
startupException = new StreamsException("Exception caught during
initialization of GlobalStreamThread", fatalException);
+ } finally {
+ initializationLatch.countDown();
Review Comment:
I don't think we need to right now, given that `start()` blocks and thus
`shutdown()` cannot be triggered as long as `init()` did not finish (cf
https://issues.apache.org/jira/browse/KAFKA-7380)
But maybe good to add to be future proof...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
