chia7712 commented on code in PR #16993:
URL: https://github.com/apache/kafka/pull/16993#discussion_r1730119616
##########
settings.gradle:
##########
@@ -27,7 +27,7 @@ develocity {
projectId = "kafka"
buildScan {
uploadInBackground = !isCI
- publishing.onlyIf { it.authenticated }
+ publishing.onlyIf { false } // Still allows users/CI to run with
--scan
Review Comment:
This is unrelated to this PR. How about CI run with `--scan` only if
`secrets.GE_ACCESS_TOKEN` is existent? That can avoid the false error
`Publishing failed.` in normal PR.
##########
.gitignore:
##########
@@ -54,8 +55,6 @@ systest/
jmh-benchmarks/generated
jmh-benchmarks/src/main/generated
**/.jqwik-database
-**/src/generated
-**/src/generated-test
Review Comment:
+1 to @gharris1727 to leave the ignores in place. Otherwise, people could
commit the generated code unexpectedly when testing 3.x branches and trunk
branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
