mjsax commented on code in PR #15482:
URL: https://github.com/apache/kafka/pull/15482#discussion_r1730427154
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java:
##########
@@ -570,7 +570,7 @@ public Optional<Set<Integer>> partitions(final String
topic, final String key, f
public void shouldUseDefaultPartitionerAsPartitionReturnsNull() {
final StreamPartitioner<String, Object> streamPartitioner =
- (topic, key, value, numPartitions) -> null;
+ (topic, key, value, numPartitions) -> Optional.empty();
Review Comment:
The test name should be updated... we used `null` for the old method, but
`empty` for the new one, which we test now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
