xijiu commented on code in PR #16998:
URL: https://github.com/apache/kafka/pull/16998#discussion_r1730499267
##########
checkstyle/suppressions.xml:
##########
@@ -221,22 +221,7 @@
files="^(?!.*[\\/]org[\\/]apache[\\/]kafka[\\/]streams[\\/].*$)"/>
<!-- Generated code -->
- <suppress
checks="(NPathComplexity|ClassFanOutComplexity|CyclomaticComplexity|ClassDataAbstractionCoupling|FinalLocalVariable|LocalVariableName|MemberName|ParameterName|MethodLength|JavaNCSS|AvoidStarImport)"
- files="streams[\\/]build[\\/]generated[\\/].+.java$"/>
- <suppress
checks="(NPathComplexity|ClassFanOutComplexity|CyclomaticComplexity|ClassDataAbstractionCoupling|FinalLocalVariable|LocalVariableName|MemberName|ParameterName|MethodLength|JavaNCSS|AvoidStarImport)"
- files="raft[\\/]build[\\/]generated[\\/].+.java$"/>
- <suppress
checks="(NPathComplexity|ClassFanOutComplexity|CyclomaticComplexity|ClassDataAbstractionCoupling|FinalLocalVariable|LocalVariableName|MemberName|ParameterName|MethodLength|JavaNCSS|AvoidStarImport)"
- files="storage[\\/]build[\\/]generated[\\/].+.java$"/>
- <suppress
checks="(NPathComplexity|ClassFanOutComplexity|CyclomaticComplexity|ClassDataAbstractionCoupling|FinalLocalVariable|LocalVariableName|MemberName|ParameterName|MethodLength|JavaNCSS|AvoidStarImport)"
- files="group-coordinator[\\/]build[\\/]generated[\\/].+.java$"/>
- <suppress
checks="(NPathComplexity|ClassFanOutComplexity|CyclomaticComplexity|ClassDataAbstractionCoupling|FinalLocalVariable|LocalVariableName|MemberName|ParameterName|MethodLength|JavaNCSS|AvoidStarImport)"
-
files="transaction-coordinator[\\/]build[\\/]generated[\\/].+.java$"/>
- <suppress
checks="(NPathComplexity|ClassFanOutComplexity|CyclomaticComplexity|ClassDataAbstractionCoupling|FinalLocalVariable|LocalVariableName|MemberName|ParameterName|MethodLength|JavaNCSS|AvoidStarImport)"
- files="share-coordinator[\\/]build[\\/]generated[\\/].+.java$"/>
-
- <suppress checks="ImportControl" files="FetchResponseData.java"/>
- <suppress checks="ImportControl" files="RecordsSerdeTest.java"/>
- <suppress checks="ImportControl" files="ClientTelemetryTest.java"/>
Review Comment:
@mumrah Hi David, thanks very much for code review, my fault, I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
