cmccabe commented on code in PR #16904:
URL: https://github.com/apache/kafka/pull/16904#discussion_r1731544689
##########
core/src/main/scala/kafka/server/ForwardingManager.scala:
##########
@@ -161,9 +178,13 @@ class ForwardingManagerImpl(
}
}
+ forwardingManagerMetrics.queueLength.getAndIncrement()
channelManager.sendRequest(envelopeRequest, new ForwardingResponseHandler)
}
+ override def close(): Unit =
Review Comment:
This is a minor point, but I don't think it makes sense for the forwarding
manager to close the metrics here. That metrics object is used by other
components, and we already have code to close it elsewhere, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
