jolshan commented on code in PR #16973:
URL: https://github.com/apache/kafka/pull/16973#discussion_r1731882824
##########
tools/src/main/java/org/apache/kafka/tools/FeatureCommand.java:
##########
@@ -282,6 +298,32 @@ static void handleDisable(Namespace namespace, Admin
adminClient) throws TerseEx
update("disable", adminClient, updates,
namespace.getBoolean("dry_run"));
}
+ static void handleVersionMapping(Namespace namespace) throws
TerseException {
+ // Get the release version from the command-line arguments or default
to the latest stable version
+ String releaseVersion =
Optional.ofNullable(namespace.getString("release_version"))
+ .orElseGet(() -> {
+ String latestVersion =
MetadataVersion.latestProduction().version();
+ System.out.println("No release version provided. Defaulting to
the latest stable version: " + latestVersion);
Review Comment:
Does this tool typically print System.out like this? I think it makes sense
for the output, but maybe it is enough to just show the version being used as
you do on line 314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
