showuon commented on PR #16866: URL: https://github.com/apache/kafka/pull/16866#issuecomment-2311527245
@cmccabe , one question: Since we only runs unclean leader election in leader imbalance thread now, which means if users disable `auto.leader.rebalance.enable`, unclean leader election also gets disabled. I think this is unexpected. Maybe we can include `uncleanLeaderElectionEnable` in this check: https://github.com/apache/kafka/blob/bf914b6982c31b62db250406b0db083867e28052/core/src/main/scala/kafka/server/ControllerServer.scala#L232 That is: `val leaderImbalanceCheckIntervalNs = if (config.uncleanLeaderElectionEnable || config.autoLeaderRebalanceEnable)`, so we will still schedule the leader imbalance thread even if autoLeaderRebalanceEnable is disabled. It's just we also need to check if `autoLeaderRebalanceEnable` is enabled or not inside `maybeTriggerLeaderChangeForPartitionsWithoutPreferredLeader` method. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
