chia7712 commented on code in PR #16983:
URL: https://github.com/apache/kafka/pull/16983#discussion_r1732617066
##########
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java:
##########
@@ -295,16 +287,6 @@ public ConsumerPerfOptions(String[] args) {
.describedAs("size")
.ofType(Integer.class)
.defaultsTo(2 * 1024 * 1024);
- numThreadsOpt = parser.accepts("threads", "DEPRECATED AND IGNORED:
Number of processing threads.")
- .withRequiredArg()
- .describedAs("count")
- .ofType(Integer.class)
- .defaultsTo(10);
- numFetchersOpt = parser.accepts("num-fetch-threads", "DEPRECATED
AND IGNORED: Number of fetcher threads.")
Review Comment:
Please update e2e file
https://github.com/apache/kafka/blob/b9fe9f532fe11c658d07b11543e874526cb837b8/tests/kafkatest/services/performance/consumer_performance.py#L127
DON'T set the removed config in the e2e when the version >= 4.0.
##########
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java:
##########
@@ -295,16 +287,6 @@ public ConsumerPerfOptions(String[] args) {
.describedAs("size")
.ofType(Integer.class)
.defaultsTo(2 * 1024 * 1024);
- numThreadsOpt = parser.accepts("threads", "DEPRECATED AND IGNORED:
Number of processing threads.")
Review Comment:
Please update e2e file
https://github.com/apache/kafka/blob/b9fe9f532fe11c658d07b11543e874526cb837b8/tests/kafkatest/services/performance/consumer_performance.py#L124
DON'T set the removed config in the e2e when the version >= 4.0.
##########
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java:
##########
@@ -265,12 +262,7 @@ protected static class ConsumerPerfOptions extends
CommandDefaultOptions {
public ConsumerPerfOptions(String[] args) {
super(args);
- brokerListOpt = parser.accepts("broker-list", "DEPRECATED, use
--bootstrap-server instead; ignored if --bootstrap-server is specified. The
broker list string in the form HOST1:PORT1,HOST2:PORT2.")
Review Comment:
Please update e2e file
https://github.com/apache/kafka/blob/b9fe9f532fe11c658d07b11543e874526cb837b8/tests/kafkatest/services/performance/consumer_performance.py#L113
set the `bootstrap-server` instead of `broker-list` when the version >= 4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
