adixitconfluent commented on code in PR #16969: URL: https://github.com/apache/kafka/pull/16969#discussion_r1732446091
########## core/src/main/java/kafka/server/share/DelayedShareFetchKey.java: ########## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package kafka.server.share; + +import kafka.server.DelayedOperationKey; + +import org.apache.kafka.common.TopicIdPartition; + +import java.util.Objects; +import java.util.Set; + +/** + * A key for delayed operations that fetch data for share consumers. + */ +public class DelayedShareFetchKey implements DelayedOperationKey { + private final Set<TopicIdPartition> topicIdPartitions; Review Comment: Hi @mumrah @junrao , I have updated DelayedShareFetchKey to have two attributes - 1. TopicIdPartition 2. GroupId Also, I have added the logic to complete a share fetch request for a purgatory key that has been acknowledged as mentioned in @mumrah's comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
