lianetm commented on code in PR #16982:
URL: https://github.com/apache/kafka/pull/16982#discussion_r1733154825
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -1053,12 +1053,20 @@ public void
testFetchStableOffsetThrowInCommitted(GroupProtocol groupProtocol) {
assertThrows(UnsupportedVersionException.class, () ->
setupThrowableConsumer(groupProtocol).committed(Collections.singleton(tp0)));
}
- // TODO: this test triggers a bug with the CONSUMER group protocol
implementation.
- // The bug will be investigated and fixed so this test can use both
group protocols.
@ParameterizedTest
- @EnumSource(value = GroupProtocol.class, names = "CLASSIC")
- public void testFetchStableOffsetThrowInPoll(GroupProtocol groupProtocol) {
- assertThrows(UnsupportedVersionException.class, () ->
setupThrowableConsumer(groupProtocol).poll(Duration.ZERO));
+ @EnumSource(GroupProtocol.class)
+ public void testFetchStableOffsetThrowInPoll(GroupProtocol groupProtocol)
throws InterruptedException {
+ setupThrowableConsumer(groupProtocol);
+ TestUtils.waitForCondition(() -> {
+ try {
+ // For CONSUMER protocol, the offset request is sent in the
background thread,
+ // so we need to wait until the offset request is sent.
+ consumer.poll(Duration.ZERO);
+ return false;
+ } catch (UnsupportedVersionException e) {
+ return true;
+ }
+ }, "Failed to fetch stable offset");
Review Comment:
I think this msg is not quite right. If this condition fails, it means that
the "consumer failed to throw UnsupportedVersionException on poll" (we actually
expect that it fails to fetch the offsets)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
