dajac commented on code in PR #17013:
URL: https://github.com/apache/kafka/pull/17013#discussion_r1734666958
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -3808,8 +3808,14 @@ class KafkaApis(val requestChannel: RequestChannel,
)
}
+ private def groupVersion(): GroupVersion = {
+
GroupVersion.fromFeatureLevel(metadataCache.features.finalizedFeatures.getOrDefault(GroupVersion.FEATURE_NAME,
0.toShort))
+ }
+
private def isConsumerGroupProtocolEnabled(): Boolean = {
- groupCoordinator.isNewGroupCoordinator &&
config.groupCoordinatorRebalanceProtocols.contains(Group.GroupType.CONSUMER)
+ groupCoordinator.isNewGroupCoordinator &&
Review Comment:
Give me a bit of time to finish everything :). My next PR will change the
default to `classic,consumer`. The plan is to have the new protocol enabled by
default in 4.0. I will do this change separately though because it requires
some cleaning too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
