chia7712 commented on code in PR #17027:
URL: https://github.com/apache/kafka/pull/17027#discussion_r1734847258
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##########
@@ -645,33 +617,23 @@ void incrementalAlterConfigs(Map<String, Config>
topicConfigs) throws ExecutionE
}
log.trace("Syncing configs for {} topics.", configOps.size());
AtomicReference<Boolean> encounteredError = new
AtomicReference<>(false);
Review Comment:
we don't need `encounteredError` now, right
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java:
##########
@@ -135,7 +134,6 @@ public MirrorSourceConnector() {
this.replicationPolicy = replicationPolicy;
Review Comment:
please remove this constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
