bbejeck commented on PR #16970: URL: https://github.com/apache/kafka/pull/16970#issuecomment-2316204644
> Not sure if using more input records by itself is the right way to go though? Seems only to reduce the likelihood that it fails? Should we maybe instead change the test condition (eg, we could count down onRestoreSuspendedLatch also in onRestoreEnd callback)? > Or we could decrease MAX_POLL_RECORDS_CONFIG to 1 to slow down restoration even more, and maybe make the RESTORATION_DELAY "dynamic" -- ie, keep it at 500ms, but after we reached a condition, reduce it to zero? True, but IMHO, reducing the `MAX_POLL_RECORD_CONFIG` is a different side of the same coin so to speak. Given that the goal of the test is to prove `onRestoreSuspended` get executed, I've removed the race condition for `onRestoreSuspended ` and now check at the end of the test it's been called at least once. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
