chia7712 commented on code in PR #16991: URL: https://github.com/apache/kafka/pull/16991#discussion_r1735432988
########## core/src/main/java/kafka/server/ServerSocketFactory.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package kafka.server; + +import org.apache.kafka.common.KafkaException; +import org.apache.kafka.common.network.Selectable; +import org.apache.kafka.common.utils.Utils; + +import java.io.IOException; +import java.net.InetSocketAddress; +import java.net.SocketException; +import java.nio.channels.ServerSocketChannel; + +public interface ServerSocketFactory { + ServerSocketChannel openServerSocket( + String listenerName, + InetSocketAddress socketAddress, + int listenBacklogSize, + int recvBufferSize + ) throws IOException; + + class KafkaServerSocketFactory implements ServerSocketFactory { + public static final KafkaServerSocketFactory INSTANCE = new KafkaServerSocketFactory(); + + @Override + public ServerSocketChannel openServerSocket( + String listenerName, + InetSocketAddress socketAddress, + int listenBacklogSize, + int recvBufferSize + ) throws IOException { + ServerSocketChannel socketChannel = null; + try { + socketChannel = ServerSocketChannel.open(); Review Comment: > there shouldn't be a resource leak in the current case where it's initialized to null, since that's handled in the catch block. oh, you are right. thanks for sharing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
