mumrah commented on code in PR #17031:
URL: https://github.com/apache/kafka/pull/17031#discussion_r1736394306


##########
.github/workflows/build.yml:
##########
@@ -82,7 +82,7 @@ jobs:
       fail-fast: false
       matrix:
         java: [ 17, 11 ]
-    if: ${{ inputs.github-actions-opt-in }}
+    if: ${{ inputs.github-actions-opt-in == 'true' }}

Review Comment:
   The issue we're having is that _all_ PRs are running the JUnit tests. Turns 
out this expression is checking `if: 'true'` or `if: 'false'` which both 
evaluate to true since they're non-empty strings. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to