ableegoldman commented on code in PR #16761:
URL: https://github.com/apache/kafka/pull/16761#discussion_r1737672790
##########
tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java:
##########
@@ -584,8 +584,8 @@ public StreamsResetterOptions(String[] args) {
.ofType(String.class)
.withValuesSeparatedBy(',')
.describedAs("list");
- intermediateTopicsOption = parser.accepts("intermediate-topics",
"Comma-separated list of intermediate user topics (topics that are input and
output topics, "
- + "e.g., used in the deprecated through() method). For
these topics, the tool will skip to the end.")
+ intermediateTopicsOption = parser.accepts("intermediate-topics",
"Comma-separated list of intermediate user topics (topics that are input and
output topics). "
Review Comment:
I'm personally fine with skipping a KIP...though it's probably correct to do
one. I'd say just write up a short and quick KIP and immediately start the
voting. This way there's at least a record of when/why was this was deprecated
and people are more likely to notice (especially since there won't be a
deprecation warning and all we can do is log a warning and hope people see it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
