sasakitoa opened a new pull request, #17058:
URL: https://github.com/apache/kafka/pull/17058

   Output format of `kafka-consumer-groups.sh` with `--delete-offsets` or 
`--reset-offsets` has been broken since line separators are missing.
   This PR will fix the problem.
   
   --
   Current: 
   ```
   $ kafka-consumer-groups.sh --bootstrap-server localhost:9092 
--delete-offsets --topic topic1 --group TestGroup1
   Request succeed for deleting offsets with topic topic1 group TestGroup1
   
   TOPIC                          PARTITION       STATUS         topic1         
                0               Successful     topic1                         1 
              Successful     topic1                         2               
Successful     topic1                         3               Successful     
topic1                         4               Successful     topic1            
             5               Successful     topic1                         6    
           Successful     topic1                         7               
Successful     topic1                         8               Successful     
topic1                         9               Successful     
   ```
   
   Expect:
   ```
   $ kafka-consumer-groups.sh --bootstrap-server localhost:9092 
--delete-offsets --topic topic1 --group TestGroup1             
   Request succeed for deleting offsets with topic topic1 group TestGroup1
   
   TOPIC                          PARTITION       STATUS         
   topic1                         0               Successful     
   topic1                         1               Successful     
   topic1                         2               Successful     
   topic1                         3               Successful     
   topic1                         4               Successful     
   topic1                         5               Successful     
   topic1                         6               Successful     
   topic1                         7               Successful     
   topic1                         8               Successful     
   topic1                         9               Successful     
   ```
   
   --
   Current: 
   ```
   $ kafka-consumer-groups.sh --bootstrap-server localhost:9092 --reset-offsets 
--from-file /tmp/offsets.csv --group TestGroup1 --execute
   
   GROUP                          TOPIC                          PARTITION  
NEW-OFFSET     TestGroup1                     topic1                         1  
        20             TestGroup1                     topic1                    
     0          10             TestGroup1                     topic1            
             3          40             TestGroup1                     topic1    
                     2          30             TestGroup1                     
topic1                         5          60             TestGroup1             
        topic1                         4          50             
   ```
   
   Expect:
   ```
   $ kafka-consumer-groups.sh --bootstrap-server localhost:9092 --reset-offsets 
--from-file /tmp/offsets.csv --group TestGroup1 --execute
   
   GROUP                          TOPIC                          PARTITION  
NEW-OFFSET     
   TestGroup1                     topic1                         1          20  
           
   TestGroup1                     topic1                         0          10  
           
   TestGroup1                     topic1                         3          40  
           
   TestGroup1                     topic1                         2          30  
           
   TestGroup1                     topic1                         5          60  
           
   TestGroup1                     topic1                         4          50  
       
   ```
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to