dajac commented on code in PR #17057:
URL: https://github.com/apache/kafka/pull/17057#discussion_r1738612665
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -576,19 +576,13 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
throw new ConfigException(s"Disabling the '${GroupType.CLASSIC}'
protocol is not supported.")
}
if (protocols.contains(GroupType.CONSUMER)) {
- if (processRoles.isEmpty) {
- throw new ConfigException(s"The new '${GroupType.CONSUMER}' rebalance
protocol is only supported in KRaft cluster.")
- }
- if (!isNewGroupCoordinatorEnabled) {
- throw new ConfigException(s"The new '${GroupType.CONSUMER}' rebalance
protocol is only supported by the new group coordinator.")
+ if (processRoles.isEmpty || !isNewGroupCoordinatorEnabled) {
+ warn(s"The new '${GroupType.CONSUMER}' rebalance protocol is only
supported in KRaft cluster with the new group coordinator.")
Review Comment:
Hum... This is too much in my opinion because it would log on every calls
from the consumers. Having a warning at the beginning seems enough for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
