chia7712 commented on code in PR #17047:
URL: https://github.com/apache/kafka/pull/17047#discussion_r1738898118
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -3382,7 +3382,43 @@ public void
testCommittedThrowsTimeoutExceptionForNoResponse(GroupProtocol group
assertEquals("Timeout of 1000ms expired before the last committed
offset for partitions [test-0] could be determined. " +
"Try tuning default.api.timeout.ms larger to relax the
threshold.", timeoutException.getMessage());
}
-
+
+ @ParameterizedTest
+ @EnumSource(value = GroupProtocol.class)
+ public void testPreventMultiThread(GroupProtocol groupProtocol) throws
InterruptedException {
Review Comment:
Could you please consider writing it by UT.
https://github.com/apache/kafka/blob/4a3ab89f95aba294bb536af55548522d946d1ee3/clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java#L2428
is a good example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
