ShivsundarR commented on code in PR #17061:
URL: https://github.com/apache/kafka/pull/17061#discussion_r1740665105
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -982,6 +941,10 @@ boolean maybeExpire() {
return numAttempts > 0 && isExpired();
}
+ /**
+ * Moves the in-flight acknowledgements for a given partition to
incomplete acknowledgements to retry
+ * in the next request.
+ */
public void moveToIncompleteAcks(TopicIdPartition tip) {
Acknowledgements acks = inFlightAcknowledgements.remove(tip);
if (acks != null) {
Review Comment:
Yeah right, we do not need the additional check here. The
`incompleteAcknowledgements` for a given `TopicIdPartition` will be initially
empty and be filled utmost once for each `ShareAcknowledgeResponse`. I have
removed this check and updated the PR. Thanks!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
