chia7712 commented on code in PR #16833:
URL: https://github.com/apache/kafka/pull/16833#discussion_r1741834420
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -981,26 +982,28 @@ private void onFailure(final long currentTimeMs,
final Errors responseError) {
log.debug("Offset fetch failed: {}", responseError.message());
onFailedAttempt(currentTimeMs);
Review Comment:
It seems `onFailedAttempt` should be called only once by one RPC. However,
`OffsetCommitRequestState` could call `onFailedAttempt` several times when the
partition-level error is `TOPIC_AUTHORIZATION_FAILED`.
https://github.com/apache/kafka/blob/c30615e6d7732b0214d59985ee5961bc9266b364/clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java#L725
@lianetm WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
