gharris1727 commented on code in PR #16950:
URL: https://github.com/apache/kafka/pull/16950#discussion_r1742487183
##########
build.gradle:
##########
@@ -1674,7 +1730,6 @@ project(':clients') {
configurations {
generator
- shadowed
Review Comment:
I don't really know what this does. Can you explain?
##########
build.gradle:
##########
@@ -320,6 +320,62 @@ subprojects {
if (shouldPublish) {
+ if (shouldPublishWithShadow) {
Review Comment:
This is part of the "subprojects" block, which applies to all subprojects,
not just clients. Since the "shadowJar" is specific to the clients, I think it
should stay where it is.
The "project.shadow.component(mavenJava)" stanza (which is also clients
specific) should be moved down to the clients-specific block. Schematically:
```
subprojects {
if (clients) {
// clients jar + publishing
} else {
// normal publishing
}
}
clients {
// nothing
}
```
should be
```
subprojects {
if (!clients) {
// normal publishing
}
}
clients {
// clients jar + publishing
}
```
An alternative could be a second `subprojects` block and moving all of the
publishing down there, but that also seems kinda confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
