apoorvmittal10 commented on code in PR #17070:
URL: https://github.com/apache/kafka/pull/17070#discussion_r1742724978
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -193,11 +194,16 @@ public static RecordState forId(byte id) {
*/
private final int maxDeliveryCount;
+ /**
+ * The group config manager is used to retrieve the values for dynamic
group configurations
+ */
+ private final GroupConfigManager groupConfigManager;
Review Comment:
Seems a bit inappropraite to have GroupConfigManager to access
`getShareGroupRecordLockDurationMs` where group-coordinator has no relevance
with `share group lock duration ms`. We should not do that.
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -116,10 +117,15 @@ public class SharePartitionManager implements
AutoCloseable {
*/
private final AtomicBoolean processFetchQueueLock;
+ /**
+ * The group config manager is used to retrieve the values for dynamic
group configurations
+ */
+ private final GroupConfigManager groupConfigManager;
Review Comment:
Same as above.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -162,6 +162,18 @@ public class GroupCoordinatorConfig {
public static final int SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DEFAULT =
15000;
public static final String SHARE_GROUP_MAX_HEARTBEAT_INTERVAL_MS_DOC =
"The maximum heartbeat interval for share group members.";
+ public static final String SHARE_GROUP_RECORD_LOCK_DURATION_MS_CONFIG =
"group.share.record.lock.duration.ms";
Review Comment:
I agree, this seems a bit ainappropriate.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -41,10 +41,14 @@ public class GroupConfig extends AbstractConfig {
public static final String CONSUMER_HEARTBEAT_INTERVAL_MS_CONFIG =
"consumer.heartbeat.interval.ms";
+ public static final String SHARE_RECORD_LOCK_DURATION_MS =
"share.record.lock.duration.ms";
Review Comment:
Why to have this config in `group-coordinator`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
