fonsdant commented on PR #17124: URL: https://github.com/apache/kafka/pull/17124#issuecomment-2339321349
> @fonsdant, let's do this for now: > > 1. Move the new files into a "committer-tools" directory > 2. Remove the Github bits > 3. Add a readme in this directory with install/setup instructions > > If the committers find ourselves really wanting some automation, we can address it in a future PR. For now, the complications of making the script reliable and dealing with automatically opening a PR seem unnecessary. Just having a script to analyze the history is quite useful and accomplishes 90% of the goal :) > > WDYT? Alright! LGTM! With _Remove the Github bits_, should I remove the PR generation, right? We still need GitHub client to get repo contributors as Josep have stated: > As we discovered in https://github.com/apache/kafka/pull/16679 using either email or author name doesn't work that nicely as people contribute with different emails (work + personal) and some people with multiple given names commit sometimes with different variations of their name. > > The fairer approach we found is applying a filter in the GitHub's collaborators page and remove committers from there. Another benefit of this is that we directly have the GitHub handles at hand. (for example https://github.com/apache/kafka/graphs/contributors?from=2023-07-24&to=2024-07-24&type=c) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
