m1a2st commented on code in PR #17128:
URL: https://github.com/apache/kafka/pull/17128#discussion_r1751505082
##########
clients/src/main/resources/common/message/ApiVersionsResponse.json:
##########
@@ -47,7 +47,7 @@
"about": "The duration in milliseconds for which the request was
throttled due to a quota violation, or zero if the request did not violate any
quota." },
{ "name": "SupportedFeatures", "type": "[]SupportedFeatureKey",
"ignorable": true,
"versions": "3+", "tag": 0, "taggedVersions": "3+",
- "about": "Features supported by the broker. Note: in v0-v3, features
with MinSupportedVersion = 0 show up with MinSupportedVersion = 1.",
+ "about": "Features supported by the broker. Note: in v0-v3, features
blocked with MinSupportedVersion = 0.",
Review Comment:
> Pardon me, I don't catch "features blocked with MinSupportedVersion = 0."
I change it to omit, it is more accurancy in this case
##########
clients/src/main/resources/common/message/ApiVersionsResponse.json:
##########
@@ -47,7 +47,7 @@
"about": "The duration in milliseconds for which the request was
throttled due to a quota violation, or zero if the request did not violate any
quota." },
{ "name": "SupportedFeatures", "type": "[]SupportedFeatureKey",
"ignorable": true,
"versions": "3+", "tag": 0, "taggedVersions": "3+",
- "about": "Features supported by the broker. Note: in v0-v3, features
with MinSupportedVersion = 0 show up with MinSupportedVersion = 1.",
+ "about": "Features supported by the broker. Note: in v0-v3, features
blocked with MinSupportedVersion = 0.",
Review Comment:
> Pardon me, I don't catch "features blocked with MinSupportedVersion = 0."
I change it to omit, it is more accurancy in this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
