rreddy-22 commented on code in PR #17093:
URL: https://github.com/apache/kafka/pull/17093#discussion_r1752565093
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -260,6 +314,20 @@ object StorageTool extends Logging {
s"${MetadataVersion.IBP_3_0_IV0}; the default is
${MetadataVersion.LATEST_PRODUCTION}")
}
+ private def addFeatureDependenciesParser(subparsers: Subparsers): Unit = {
Review Comment:
No we don't, this is ensured using store() which only allows one value. If
multiple values are provided it takes the last one. Do we want to throw an
exception if multiple features are listed or are we fine with the default
behavior?
> featureDependenciesParser.addArgument("--feature", "-f")
.required(true)
.help("The feature and version to look up dependencies for, in
feature=level format." +
" For example: `metadata.version=5`."
)
.action(store())
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
