chenyulin0719 commented on code in PR #17117:
URL: https://github.com/apache/kafka/pull/17117#discussion_r1753077397
##########
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##########
@@ -85,6 +88,9 @@ static List<ClusterConfig> forKRaftGroupCoordinator() {
Map<String, String> serverProperties = new HashMap<>();
serverProperties.put(OFFSETS_TOPIC_PARTITIONS_CONFIG, "1");
serverProperties.put(OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG, "1");
+ serverProperties.put(GROUP_INITIAL_REBALANCE_DELAY_MS_CONFIG, "1000");
Review Comment:
Hi @m1a2st, one question, based on the document of
`group.initial.rebalance.delay.ms`.
([Link](https://kafka.apache.org/documentation/#consumerconfigs_max.poll.interval.ms:~:text=A%20new%20config,up%20to%20a))
> The default value for this is 3 seconds. During development and testing it
might be desirable to set this to 0 in order to not delay test execution time.
I think setting `group.initial.rebalance.delay.ms` to zero might be better.
Is there have any reason we use 1000 ms?
I can see some tests are using 1000ms, but some others are using 0ms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
