mjsax commented on code in PR #17170:
URL: https://github.com/apache/kafka/pull/17170#discussion_r1755868687
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -1775,11 +1735,7 @@ public Map<String, Object> getProducerConfigs(final
String clientId) {
props.putAll(getClientCustomProps());
props.putAll(clientProvidedProps);
- // When using EOS alpha, stream should auto-downgrade the
transactional commit protocol to be compatible with older brokers.
- if (StreamsConfigUtils.processingMode(this) ==
StreamsConfigUtils.ProcessingMode.EXACTLY_ONCE_ALPHA) {
- props.put("internal.auto.downgrade.txn.commit", true);
- }
-
+ // TODO: given that we remove this code, it seems we can remove the
corresponding tests (cf other TODO)
Review Comment:
Open question (we can resolve in this PR). Refers to removing the code above
which sets `internal.auto.downgrade.txn.commit`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
