apoorvmittal10 commented on code in PR #17176:
URL: https://github.com/apache/kafka/pull/17176#discussion_r1756736312
##########
checkstyle/import-control-coordinator-common.xml:
##########
@@ -40,6 +40,9 @@
<subpackage name="coordinator">
<subpackage name="common">
+
+ <allow pkg="org.apache.kafka.common" />
Review Comment:
Line number 34 - 39 above defines common classes. Which common package do we
need explitily, can we please include that above.
##########
core/src/test/java/kafka/test/ClusterTestExtensionsTest.java:
##########
@@ -202,7 +202,7 @@ public void testSupportedNewGroupProtocols(ClusterInstance
clusterInstance) {
@ClusterTests({
@ClusterTest(types = {Type.ZK, Type.KRAFT, Type.CO_KRAFT},
serverProperties = {
- @ClusterConfigProperty(key =
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, value = "classic"),
+ @ClusterConfigProperty(key =
GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, value = "Classic"),
Review Comment:
Why this change is required?
##########
checkstyle/import-control-share.xml:
##########
@@ -33,6 +33,9 @@
<!-- anyone can use public classes -->
<allow pkg="org.apache.kafka.common" exact-match="true" />
<allow pkg="org.apache.kafka.common.utils" />
+ <allow pkg="org.apache.kafka.common.config" />
+ <allow pkg="org.apache.kafka.common.errors" />
+ <allow pkg="org.apache.kafka.coordinator.common" />
Review Comment:
Seems not the right section to include `coordinator`.
##########
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala:
##########
@@ -72,7 +72,7 @@ abstract class IntegrationTestHarness extends
KafkaServerTestHarness {
cfgs.foreach(_.setProperty(KRaftConfigs.MIGRATION_ENABLED_CONFIG,
"true"))
}
if (isShareGroupTest()) {
-
cfgs.foreach(_.setProperty(GroupCoordinatorConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG,
"classic,consumer,share"))
+
cfgs.foreach(_.setProperty(CoordinatorCommonConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG,
"Classic,Consumer,Share"))
Review Comment:
Why do we need to change `"Classic,Consumer,Share"`?
##########
core/src/test/scala/unit/kafka/server/ConsumerGroupHeartbeatRequestTest.scala:
##########
@@ -43,7 +44,7 @@ class ConsumerGroupHeartbeatRequestTest(cluster:
ClusterInstance) {
@ClusterTest(
types = Array(Type.KRAFT),
serverProperties = Array(
- new ClusterConfigProperty(key =
GroupCoordinatorConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, value =
"classic"),
+ new ClusterConfigProperty(key =
CoordinatorCommonConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, value =
"Classic"),
Review Comment:
Agains same is `Classic` change is required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
