mjsax commented on code in PR #17091:
URL: https://github.com/apache/kafka/pull/17091#discussion_r1757750409
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -1820,6 +1820,7 @@ void addRecordsToTasks(final ConsumerRecords<byte[],
byte[]> records) {
}
activeTask.addRecords(partition, records.records(partition));
+ activeTask.setNextOffsetsAndMetadata(records.nextOffsets());
Review Comment:
Would it be better to not add `setNextOffsetsAndMetadata` but make it part
of `addRecord` to begin with?
In the end, we only need to pass in `nextRecord.offset` for the `partition`
we are currently processing, plus a leader epoch, but not the full map of
`nextRecords()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
