cmccabe commented on code in PR #17076:
URL: https://github.com/apache/kafka/pull/17076#discussion_r1759193919
##########
docs/quickstart.html:
##########
@@ -50,46 +50,47 @@ <h5>Kafka with KRaft</h5>
<p>Kafka can be run using KRaft mode using local scripts and
downloaded files or the docker image. Follow one of the sections below but not
both to start the kafka server.</p>
- <h5>Using downloaded files</h5>
+ <h6>Using downloaded files</h6>
<p>Generate a Cluster UUID</p>
- <pre><code class="language-bash">$
KAFKA_CLUSTER_ID="$(bin/kafka-storage.sh random-uuid)"</code></pre>
+ <pre><code
class="language-bash">KAFKA_CLUSTER_ID="$(bin/kafka-storage.sh
random-uuid)"</code></pre>
<p>Format Log Directories</p>
- <pre><code class="language-bash">$ bin/kafka-storage.sh format -t
$KAFKA_CLUSTER_ID -c config/kraft/server.properties</code></pre>
+ <pre><code class="language-bash">bin/kafka-storage.sh format
--standalone -t $KAFKA_CLUSTER_ID -c
config/kraft/reconfig-server.properties</code></pre>
Review Comment:
It's more important to document `--initial-controllers` than `-standalone`.
If only one way is going to be documented, it should certainly be
`--initial-controllers`. (But I think documenting both is reasonable.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
